Closed ejeschke closed 1 year ago
@olebole, a couple questions for you, if you'd be so kind:
ginga.desktop
so that the icon path is set correctly?So with this patch, this this file outdated?
https://github.com/ejeschke/ginga/blob/master/ginga/icons/ginga-512x512.png
For, this looks nice. I don't need a "preferred size".
In ginga.desktop
, you just need to add ginga.svg
as you did, and install the icon file where it can be found (/usr/share/pixmaps
on Debian).
and install the icon file where it can be found (/usr/share/pixmaps on Debian).
Can your Debian packaging script for apt put it in the right place if it is in ginga/icons in the repo or ginga/icons in the PyPI package?
So with this patch, this this file outdated?
https://github.com/ejeschke/ginga/blob/master/ginga/icons/ginga-512x512.png
Possibly. I'll do a quick check to see if it is used anywhere and add its removal to this PR if not.
@ejeschke
Can your Debian packaging script for apt put it in the right place if it is in ginga/icons in the repo or ginga/icons in the PyPI package?
The Debian package will put it to the right place, so after "apt install ginga" all will be fine.
@pllim, are you ok with the design? If not, maybe accept for now and we figure out a different one later?
I don't have any opinion on the logo. Feel free to merge. Thanks!
ginga-512x512.png
is currently used by one of the examples. We will keep it in the repo for the present.
Thank you @pllim and @olebole!
Adds a new SVG based icon for Ginga.