ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

Add a new Ginga SVG icon #1018

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago

Adds a new SVG based icon for Ginga.

ejeschke commented 1 year ago

@olebole, a couple questions for you, if you'd be so kind:

pllim commented 1 year ago

So with this patch, this this file outdated?

https://github.com/ejeschke/ginga/blob/master/ginga/icons/ginga-512x512.png

olebole commented 1 year ago

For, this looks nice. I don't need a "preferred size". In ginga.desktop, you just need to add ginga.svg as you did, and install the icon file where it can be found (/usr/share/pixmaps on Debian).

ejeschke commented 1 year ago

and install the icon file where it can be found (/usr/share/pixmaps on Debian).

Can your Debian packaging script for apt put it in the right place if it is in ginga/icons in the repo or ginga/icons in the PyPI package?

ejeschke commented 1 year ago

So with this patch, this this file outdated?

https://github.com/ejeschke/ginga/blob/master/ginga/icons/ginga-512x512.png

Possibly. I'll do a quick check to see if it is used anywhere and add its removal to this PR if not.

olebole commented 1 year ago

@ejeschke

Can your Debian packaging script for apt put it in the right place if it is in ginga/icons in the repo or ginga/icons in the PyPI package?

The Debian package will put it to the right place, so after "apt install ginga" all will be fine.

ejeschke commented 1 year ago

@pllim, are you ok with the design? If not, maybe accept for now and we figure out a different one later?

pllim commented 1 year ago

I don't have any opinion on the logo. Feel free to merge. Thanks!

ejeschke commented 1 year ago

ginga-512x512.png is currently used by one of the examples. We will keep it in the repo for the present.

ejeschke commented 1 year ago

Thank you @pllim and @olebole!