search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Fix a DeprecationWarning related to entry points in Python 3.11+ #1036

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago
pllim commented 1 year ago

I am curious on why the CI here never caught this deprecation warning. This repo turns unhandled warnings to failure, and also use Python 3.11 in devdeps job. Is the entry point not tested here?

ejeschke commented 1 year ago

I am curious on why the CI here never caught this deprecation warning

Did we have a Python 3.11 test in the CI?

pllim commented 1 year ago

Yes, this picks up 3.11 now

https://github.com/ejeschke/ginga/blob/e78704e829509eba9a6ea0cab97018d8158c3465/.github/workflows/ci_workflows.yml#L98

See https://github.com/ejeschke/ginga/actions/runs/3700111770/jobs/6268210347