ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Change implementation of splash ("About") dialog #1039

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago
ejeschke commented 1 year ago

@pllim, absolutely no hurry on this one. Just a small and cosmetic change.

pllim commented 1 year ago

TBH, I never understood why splash banner was needed. In other commercial software, it only pops up when you go to Help and click About. Is that what this is doing?

ejeschke commented 1 year ago

It only pops up the first time you run the program and thereafter only when you select the "About" item from the Help menu. It can (and is) suppressed by putting a "noBanner = True" in your $HOME/.ginga/general.cfg. It does this automatically the first time you run the program.

The only difference from the past is that in the past implementation it popped up as a "Ginga" channel tab, but with no mention of the version.

pllim commented 1 year ago

In that case, feel free to merge. Thanks!

ejeschke commented 1 year ago

Thanks, @pllim!