ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
122 stars 77 forks source link

readthedocs deprecations #1060

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago

@pllim, received the following email. Looking at our .readthedocs.yml, it looks like we are already skipping the system packages option. Do you see anything in your readthedocs build that would require an update due to this?

You are receving this email because your Read the Docs project is impacted by an upcoming deprecation. Read the Docs used to pre-install common scientific Python packages like scipy, numpy, pandas, matplotlib and others at system level to speed up the build process. However, with all the work done in the Python ecosystem and the introduction of "wheels", these packages are a lot easier to install via pip install and these pre-installed packages are not required anymore. If you have Apt package dependencies, they can be installed with build.apt_packages. With the introduction of our new "Ubuntu 20.04" and "Ubuntu 22.04" Docker images, we stopped pre-installing these extra Python packages and we encouraged users to install and pin all their dependencies using a requirements.txt file. We have already stopped supporting "use system packages" on these newer images. We are removing the "use system packages" feature on August 29th. Make sure you are installing all the required dependecies to build your project's documentation using a requirements.txt file and specifying it in your .readthedocs.yaml. Here you have an example of the section required on the .readthedocs.yaml configuration file: python: install: - requirements: docs/requirements.txt The content of docs/requirements.txt would be similar to: scipy==1.11.1 numpy==1.25.2 pandas==2.0.3 matplotlib==3.7.2 We are sending you this email because you are a maintainer of the following projects that are affected by this removal. Either using "Use system package" checkbox in the Admin UI, or the config key python.sytem_packages or python.use_system_site_packages in your .readthedocs.yaml file: ginga Read more about this in our Reproducible builds guide for more details.

Keep documenting, Read the Docs

You are receving this email because your Read the Docs project is impacted by an upcoming deprecation.

Read the Docs used to pre-install common scientific Python packages like scipy, numpy, pandas, matplotlib and others at system level to speed up the build process. However, with all the work done in the Python ecosystem and the introduction of "wheels", these packages are a lot easier to install via pip install and these pre-installed packages are not required anymore. If you have Apt package dependencies, they can be installed with build.apt_packages.

With the introduction of our new "Ubuntu 20.04" and "Ubuntu 22.04" Docker images, we stopped pre-installing these extra Python packages and we encouraged users to install and pin all their dependencies using a requirements.txt file. We have already stopped supporting "use system packages" on these newer images.

We are removing the "use system packages" feature on August 29th. Make sure you are installing all the required dependecies to build your project's documentation using a requirements.txt file and specifying it in your .readthedocs.yaml.

Here you have an example of the section required on the .readthedocs.yaml configuration file:

python: install:

  • requirements: docs/requirements.txt

The content of docs/requirements.txt would be similar to:

scipy==1.11.1 numpy==1.25.2 pandas==2.0.3 matplotlib==3.7.2

We are sending you this email because you are a maintainer of the following projects that are affected by this removal. Either using "Use system package" checkbox in the Admin UI, or the config key python.sytem_packages or python.use_system_site_packages in your .readthedocs.yaml file:

[ginga](https://readthedocs.org/projects/ginga/)

Read more about this in our Reproducible builds guide for more details. Keep documenting, Read the Docs

ejeschke commented 1 year ago

Looks like we should put together a requirements.txt file and include it in the .readthedocs.yml file.

pllim commented 1 year ago

I don't think we need to do anything. We already do not use system packages:

https://github.com/ejeschke/ginga/blob/67148e3482022639d31a2013b6d85c6bf88cf515/.readthedocs.yml#L19-L25

ejeschke commented 1 year ago

Hmm, I'm seeing this again in this build