search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
122 stars 77 forks source link

Fix readthedocs build due to sphinx incompatibility with RTD theme #1063

Closed ejeschke closed 1 year ago

ejeschke commented 1 year ago
ejeschke commented 1 year ago

A bit hacky, but I guess we can revert it once sphinx 7.x supports the RTD theme. LMK what you think @pllim

pllim commented 1 year ago

This seems a little excessive. Why not pin it here?

https://github.com/ejeschke/ginga/blob/cf221462286cc8f9003975cfd0bccf57d8e16acc/setup.cfg#L67

ejeschke commented 1 year ago

This seems a little excessive. Why not pin it here?

https://github.com/ejeschke/ginga/blob/cf221462286cc8f9003975cfd0bccf57d8e16acc/setup.cfg#L67

If that works, I'm all for it! Can I say:

docs = sphinx<7.0, sphinx-astropy; sphinx_rtd_theme

?

ejeschke commented 1 year ago

It works! LGTM, @pllim?

ejeschke commented 1 year ago

I will squash out the previous commits.

ejeschke commented 1 year ago

Thanks, @pllim!