Feature vizier catalogs

ejeschke / ginga

The Ginga astronomical FITS file viewer

BSD 3-Clause "New" or "Revised" License

120 stars 77 forks source link

Feature vizier catalogs #1064

Closed ebroens closed 10 months ago

ebroens commented 10 months ago

Dear Dr. Jeschke,

I have added support for vizier catalogs, with APASS DR9 as the default catalog source. It includes:

the possibility to do a box query limited to the image, hence no need to use the "limit stars to area" option and no obsolete data returned in the query
the possibility to return only specific catalog columns of interest
vizier catalogs can have NaN values for magnitudes, for these only a point is plotted and no circle. NaN values are not taken into account for the color coding range.

Would be great if you could merge this feature.

Thanks, Eric Broens

ejeschke commented 10 months ago

@ebroens , the one CI failure looks like it's in the documentation build. Could you rebase your PR? There was a fix for the RTD build failure posted to the main branch very recently.

ebroens commented 10 months ago

@ebroens , the one CI failure looks like it's in the documentation build. Could you rebase your PR? There was a fix for the RTD build failure posted to the main branch very recently.

@ejeschke, the PR has been rebased now too.

ejeschke commented 10 months ago

@pllim, any objection to a squash merge?

pllim commented 10 months ago

@ejeschke , as long as you are okay with it, squash merge is fine by me. 😸

pllim commented 10 months ago

Does this need a change log?

ejeschke commented 10 months ago

Does this need a change log?

Yes, good point. @ebroens, can you add something about this to doc/WhatsNew.rst? Just push another commit on this branch.

ebroens commented 10 months ago

Does this need a change log?

Yes, good point. @ebroens, can you add something about this to doc/WhatsNew.rst? Just push another commit on this branch.

@ejeschke, WhatsNew.rst has been updated.

ejeschke commented 10 months ago

Thanks, @ebroens !