ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

Tag and push 4.1.1 #1069

Closed tbowers7 closed 10 months ago

tbowers7 commented 10 months ago

I work with the PypeIt development team, and we are seeing an issue on certain platforms where ginga crashes upon clearing a canvas in advance of displaying images from within PypeIt.

The crash happens with the pip-installed ginga-4.1.0, but not with ginga-4.0.1 or installing ginga directly from the current main branch here on GitHub (listed by pip as 4.1.1.dev18+g4815b44). We conclude that there was some issue introduced in version 4.1.0 that has since been resolved. We request that the current main be tagged and released to resolve this issue when installing the latest version of ginga via pip/PyPI.

pllim commented 10 months ago

There were new features merged since, so looks like it has to be at least a 4.2. What do you think, @ejeschke ?

ejeschke commented 10 months ago

I have a 4.1.x branch queued up for a 4.1.1 release. I would be comfortable releasing that ASAP. @tbowers7, could you check whether that branch fixes the issue for you?

I had a tentative release date of October for v5.0, but I don't anticipate major changes before then, so it would also be possible to move that up.

tbowers7 commented 10 months ago

@ejeschke, yes, I can confirm that the 4.1.x branch works as expected (no crash), whereas the v4.1.0 tag does crash.

FWIW, here is the traceback for one of the crash modes of v4.1.0, if it will help diagnose any other possible issues:

  File "/Users/tbowers/d1/codes/PypeIt/pypeit/display/display.py", line 157, in show_image
    ch.load_np(chname, img, 'fits', header)
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/site-packages/ginga/util/grc.py", line 89, in load_np
    return load_buffer(imname, self._chname,
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/site-packages/ginga/util/grc.py", line 189, in call
    res = self._proxy.dispatch_call(method_name, p_args, p_kwdargs)
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 1122, in __call__
    return self.__send(self.__name, args)
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 1464, in __request
    response = self.__transport.request(
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 1166, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 1182, in single_request
    return self.parse_response(resp)
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 1354, in parse_response
    return u.close()
  File "/Users/tbowers/opt/miniconda3/envs/pypeit/lib/python3.10/xmlrpc/client.py", line 668, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault 1: "<class 'AttributeError'>:'ValueError' object has no attribute 'name'">
ejeschke commented 10 months ago

@tbowers7, ginga v4.1.1 has been released. It's on PyPI and will be out soon on conda-forge.