ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

Fixes for numpy 2.0 #1072

Closed ejeschke closed 9 months ago

ejeschke commented 10 months ago

To make ginga compatible with numpy 2.0.

This will continue to be updated as more of the third party packages become available (scipy, matplotlib, etc).

ejeschke commented 10 months ago

There seems to be very little needed to be changed, so far.

pllim commented 10 months ago

Actually both scipy and matplotlib dev are available from https://anaconda.org/scientific-python-nightly-wheels/repo too.

ejeschke commented 10 months ago

Haven't yet installed scipy or matplotlib. This is tested so far with numpy 2.0 nightly and astropy (6.0+ dev) and pillow 10.

ejeschke commented 10 months ago

Actually both scipy and matplotlib dev are available from https://anaconda.org/scientific-python-nightly-wheels/repo too.

So I managed to install both of these. Seems to be working well. FYI I installed python 11 with pyside6 as the back end.

pllim commented 10 months ago

Great news. Thanks for checking!

ejeschke commented 9 months ago

@pllim, this is passing all tests when I run them locally. After testing a number of plugins pretty thoroughly, I am thinking that we could merge this. If new issues arise with np2 we can fix them when they pop up. What do you think?

ejeschke commented 9 months ago

Thanks, @pllim!