ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
122 stars 77 forks source link

RTD: Rename YAML file #1078

Closed pllim closed 11 months ago

pllim commented 11 months ago

I think this is required for RTD to build now.

pllim commented 11 months ago

I still do not see the RTD job here. Could be the webhook is broken but I cannot see the GitHub admin settings here. On RTD site, it is getting Error 400 .

ejeschke commented 11 months ago

Webhook is still enabled, but is showing the error that 400 is happening on the RTD side.

BTW, there is still a travis web hook--not using that now are we? Should we delete it? It's showing invalid HTTP response 503. Also, the appveyor one is also signalling an error: invalid HTTP response 403

pllim commented 11 months ago

You do not need Travis CI or Appveyor CI webhooks.

You do, however, need to fix the ReadTheDocs webhook. I couldn't fix it from the RTD side. What is it saying on the GitHub side?

ejeschke commented 11 months ago

"Last delivery was not successful. Invalid HTTP response: 400."

ejeschke commented 11 months ago

Let me poke around the RTD side...

pllim commented 11 months ago

Is it complaining about invalid token on GH side?

ejeschke commented 11 months ago

Shows "passing" on RTD side.

ejeschke commented 11 months ago

Is it complaining about invalid token on GH side

Not that I can see anywhere.

ejeschke commented 11 months ago

There is no secret in the secret box, however

pllim commented 11 months ago

Do you see this?

Screenshot 2023-12-04 172712

If so:

  1. Click Change Secret.
  2. Leave blank.
  3. Update Webhook.
  4. Then you can test it by re-deploying the last failed delivery.
ejeschke commented 11 months ago

No, this: image

pllim commented 11 months ago

Hmm why is it not JSON?

ejeschke commented 11 months ago

I just kicked off a build on RTD of "latest". Double-checked that it is the correct SHA. It used the command "cat .readthedocs.yml" and successfully completed the build. So I don't think the file extension is the issue...

ejeschke commented 11 months ago

Should I try switch to JSON?

pllim commented 11 months ago

OK closing this PR then.

Should I try switch to JSON?

Doesn't hurt at this point. 😅

ejeschke commented 11 months ago

Ok, I rebased #1076 and force pushed it. Let's see what happens...

ejeschke commented 11 months ago

Still getting a 400 code from RTD...

pllim commented 11 months ago

Looks like it is still failing. There is a message on the RTD integration page for the webhook:

This integration is not managed by Read the Docs currently. If this integration is not functioning correctly, you can try re-syncing it. Otherwise you'll need to update the configuration on your repository. You can use the following address to manually configure this webhook.

To manually configure this webhook with your provider, use the following information...

ejeschke commented 11 months ago

Ah, there was a secret there--I have pasted this into the github side. I'll try force pushing #1076 again.

ejeschke commented 11 months ago

On the RTD side, for the HTTP 400 failures, it is showing the following message:


{
  "detail": "Payload not valid, invalid or missing signature"
}
ejeschke commented 11 months ago

Under Integrations/Exchange--can you see it?

ejeschke commented 11 months ago

Hmmm, thinking I might have to try the solution here...

pllim commented 11 months ago

Might as well give that a try. Good luck!