search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
120 stars 77 forks source link

ENH: Compass N-E to be more robust #1102

Closed pllim closed 1 month ago

pllim commented 1 month ago

Compass N-E to be more robust by using small angular offsets when determining compass properties.

This is from https://github.com/spacetelescope/jdaviz/pull/2867 by @astrofrog on the same piece of algorithm we borrowed from Ginga (https://github.com/spacetelescope/jdaviz/blob/main/licenses/GINGA_LICENSE.txt).

pllim commented 1 month ago

You might want to actually see how it renders with your data before merge. Thanks!

ejeschke commented 1 month ago

LGTM, FFTM

ejeschke commented 1 month ago

:pray:

pllim commented 1 month ago

Thanks to @astrofrog !