TST: Update CI workflow

pllim commented 3 years ago

This pull request updates the CI workflow in the following ways:

~Change pull_request: to pull_request_target:, which according to https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull_request_target, "prevents executing unsafe workflow code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow."~ I reverted this so the CI runs on this PR. I am also confused by the documentation on GitHub and awaiting their clarification. UPDATE: No, should not use pull_request_target.
Use https://github.com/pllim/action-check_pr_basebranch to ensure that PR is always opened against master branch. In the rare event where we need to push to gh-pages, we could use the skip-basebranch-check label to skip the check (apply it at the same time as you open the PR).
Use https://github.com/pllim/action-skip-ci to allow [ci skip] to work in a PR.
Use https://github.com/styfle/cancel-workflow-action to allow cancelling duplicate workflow runs.
Use twine check --strict option to have it fail when the check finds warning. This is only available for twine>=3.3.
Let dev job run on Python 3.9 now that we can do it.

ejeschke commented 3 years ago

I am also confused by the documentation on GitHub and awaiting their clarification.

So, not quite ready for review?

pllim commented 3 years ago

So, not quite ready for review?

It is ready for review. I'll just not worry about the pull_request vs pull_request_target for now.

pllim commented 3 years ago

Update: I modified the skip CI action to skip the CI without failing, so I updated the PR.

pllim commented 3 years ago

[ci skip] is supported natively now and the rest isn't important enough for this repo to keep this going. If there is certain things you wish to revisit, please let me know and I can open new PRs with just those things. Thanks!

ejeschke commented 3 years ago

@pllim, sorry, I didn't really get a chance to understand this PR completely. I was not uninterested, just hadn't really gotten time to have a good long look at it.

pllim commented 3 years ago

No worries!

ejeschke / ginga

TST: Update CI workflow #918