ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Add orientation setting to all plugins that are orientable #929

Closed ejeschke closed 3 years ago

ejeschke commented 3 years ago

Adds an "orientation" setting to all plugins that use the "get_oriented_box" function. It allows the user to fix (override) the auto-orientation.

ejeschke commented 3 years ago

@pllim, have look when you get the chance. We have an instance of Ginga in the observation system where the layout is such that the primary orientation for the plugins is horizontal, but due to our (somewhat) recent change of requiring an aspect ratio of 2.0 to force a horizontal layout, they do not lay out as desired. This PR simply allow one to put e.g. orientation='horizontal' in the plugin settings file and this would override the auto-orientation.

pllim commented 3 years ago

p.s. Feel free to merge. 😸