search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Merge wcs_astropy and wcs_astropy_ape14 #959

Open pllim opened 3 years ago

pllim commented 3 years ago

Particularly, wcs_astropy_ape14 should just be renamed to wcs_astropy. At the same time, we deprecate wcs_astropy_ape14 and eventually remove it. So there should be only one astropy WCS interface and it is the one that follows Astropy APE 14.

As suggested by @ejeschke in https://github.com/ejeschke/ginga/pull/823#issuecomment-850755829.

ejeschke commented 3 years ago

I think that as long as the one we end up with is working as well as the other (plus the extra functionality), then we are good. This is a little bit tricky issue because the WCS is used for sooo many different files!

pllim commented 3 years ago

I don't understand why the hack is there and why it needs such a big offset (1 degree in the sky). When there is distortion, such a big offset outside of the detector is not going to give you anything good.

pllim commented 3 years ago

Oh ops... I replied to the wrong issue.