Entry points: Replace pkg_resources with importlib

ejeschke / ginga

The Ginga astronomical FITS file viewer

BSD 3-Clause "New" or "Revised" License

121 stars 77 forks source link

Entry points: Replace pkg_resources with importlib #963

Closed pllim closed 3 years ago

pllim commented 3 years ago

See https://github.com/conda-forge/ginga-feedstock/pull/12#issuecomment-856332510 onwards.

https://packaging.python.org/specifications/entry-points/

ejeschke commented 3 years ago

$ grep -R -l pkg_resources ginga
ginga/misc/__init__.py
ginga/qtw/__init__.py
ginga/rv/plugins/__init__.py
ginga/rv/main.py
ginga/__init__.py

ejeschke commented 3 years ago

@pllim, I don't know about the ones in the __init__.py's. I think I was responsible for the one in main.py, because that one is used to load externally defined plugins, via entry points.

ejeschke commented 3 years ago

Shall I start a PR? May need your help figuring out what the ones in all the init's are for...

pllim commented 3 years ago

Go ahead. Will be happy to help if you need it. I don't remember why I needed special entry point code either. As long as it doesn't break existing downstream stuff on my side, it's fine by me. Thanks!