search

ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Add NoConvergence workaround for radectopix in wcs_astropy.py #974

Closed ejeschke closed 2 years ago

ejeschke commented 2 years ago

Fixes the routines radectopix and wcspt_to_datapt in the WCS wrapper for astropy so that if the convergence fails it falls back to the best solution (based on the information in this issue).

The rationale for this is that these routines are mainly used for routines like drawing a compass, etc and do not need extreme accuracy of solution.

ejeschke commented 2 years ago

@pllim, can #967 use this technique? What do you think?

pllim commented 2 years ago

Thanks! But I might not have time to review for a few weeks. Is this urgent?

ejeschke commented 2 years ago

No worries, @pllim. Not sure a review is even necessary for this.