ejeschke / ginga

The Ginga astronomical FITS file viewer
BSD 3-Clause "New" or "Revised" License
121 stars 77 forks source link

Remove save_primary_header, inherit_primary_header attributes #985

Closed ejeschke closed 2 years ago

ejeschke commented 2 years ago

This begins the removal of the save_primary_header and inherit_primary_header attributes and kwargs from AstroImage. The saving of the primary header is done when loading an image through the io_fits module and it is merged when include_primary_header==True in the AstroImage get_header() method.

The two kwargs issue a deprecation warning if used when creating an AstroImage.

ejeschke commented 2 years ago

@pllim, in line with your comments for deprecation of API on #978.

ejeschke commented 2 years ago

Rebased

ejeschke commented 2 years ago

@pllim, ok to merge?

ejeschke commented 2 years ago

Thanks, @pllim!