search

ejfinneran / ratelimit

A Redis-backed rate limiter written in Ruby
MIT License
257 stars 55 forks source link

Readme updates #22

Closed jeremywadsack closed 8 years ago

jeremywadsack commented 8 years ago

The link in the README to the blog post that inspired this project is broken. Chriso republished the post as a gist so I fixed the link to point to that.

When reading the instructions it wasn't clear to me that the #exec_within_threshold method wouldn't also increment the counter, until I read the code. I get why it doesn't — it wouldn't know how many API calls were made inside the block. But I thought it would help others in the example code to include the call to #add to show that the counter needs to be incremented as well.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.138% when pulling 2df7a6d46b2d6422ff2fed14a197147b836c3d2f on jeremywadsack:readme_updates into aa8bd7a71e263a86451a75216589d408fa133342 on ejfinneran:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.138% when pulling 2df7a6d46b2d6422ff2fed14a197147b836c3d2f on jeremywadsack:readme_updates into aa8bd7a71e263a86451a75216589d408fa133342 on ejfinneran:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.138% when pulling 2df7a6d46b2d6422ff2fed14a197147b836c3d2f on jeremywadsack:readme_updates into aa8bd7a71e263a86451a75216589d408fa133342 on ejfinneran:master.

ejfinneran commented 8 years ago

Thanks!