Fix counting the same buckets multiple times when the interval > bucket_span - Githubissues

ejfinneran / ratelimit

A Redis-backed rate limiter written in Ruby

MIT License

257 stars 55 forks source link

Fix counting the same buckets multiple times when the interval > bucket_span #28

Closed dvandersluis closed 7 years ago

dvandersluis commented 7 years ago

I ran into a problem where count was returning multiples of what was expected, and discovered it was due to the interval being given to count being greater than what was expected when setting up the bucket. In this case, the same buckets were being pulled repeatedly, hence the multiple.

Please let me know if I'm misunderstanding anything!

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.2% when pulling f29011328add022afd353546a1209f328b25ec70 on hyp3rventures:master into 177b1bf654f027705566cf2520fcd1ca0dc41536 on ejfinneran:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.2% when pulling f29011328add022afd353546a1209f328b25ec70 on hyp3rventures:master into 177b1bf654f027705566cf2520fcd1ca0dc41536 on ejfinneran:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 98.413% when pulling f29011328add022afd353546a1209f328b25ec70 on hyp3rventures:master into 177b1bf654f027705566cf2520fcd1ca0dc41536 on ejfinneran:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.2% when pulling 55ebeedf11737b94be193b47e25cb3ec2cf0b15b on hyp3rventures:master into 177b1bf654f027705566cf2520fcd1ca0dc41536 on ejfinneran:master.

coveralls commented 7 years ago

Coverage decreased (-0.8%) to 98.413% when pulling 55ebeedf11737b94be193b47e25cb3ec2cf0b15b on hyp3rventures:master into 177b1bf654f027705566cf2520fcd1ca0dc41536 on ejfinneran:master.

ejfinneran commented 7 years ago

Thank you!

ejfinneran commented 7 years ago

Pushed 1.0.3 that contains this fix. https://rubygems.org/gems/ratelimit/versions/1.0.3