search

ejfinneran / ratelimit

A Redis-backed rate limiter written in Ruby
MIT License
257 stars 55 forks source link

Remove redis deprecation warning #41

Closed andreasknoepfle closed 1 year ago

andreasknoepfle commented 2 years ago

Fix #40

Switch to new multi syntax in #add call.

See https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#460

This syntax was introduced in 3.0.0 and the old style will be deprecated in 5.0.0.

andreasknoepfle commented 2 years ago

Ahh, just noticed that there was a PR on this already #39, but the other one does not change the redis version, so maybe I leave this open.

andreasknoepfle commented 2 years ago

Hello @ejfinneran Is there anything I can do to bring this forward? Can we have a new release with this?

ejfinneran commented 2 years ago

@andreasknoepfle Apologies! I haven't been writing Ruby recently and I don't have much time to maintain this anymore. Are you interested in taking over? I can add you to the repo and give you access to publish the rubygem if so.

andreasknoepfle commented 2 years ago

Hey @ejfinneran,

I totally understand. I am also only writing Ruby code to maintain some older projects. But since our company uses this gem in production still I'd be happily taking over this time to do a release etc. I just don't know if I can promise a lot of dedication to this myself, but I can try to help maintaining if other topics arise.

VikiAnn commented 2 years ago

I can also help! We use this at my company as well and I was just investigating this exact change.

ejfinneran commented 2 years ago

@VikiAnn @andreasknoepfle I added both of you as collaborators. I'm happy to add you to as owners of the gem in rubygems too.

ejfinneran commented 2 years ago

@VikiAnn Yes! Shoot me an email with your rubygems account/email and I'll add you. ej.finneran@gmail.com

andreasknoepfle commented 1 year ago

Merged and email is sent. Let me know when you have added me to Rubygems. I am soon working again for a bit on the project for a few days where we use this gem, so I'll also have a look at the other issues and draft a new release then.