Adapt to coq/coq#18771 (Improve handling of Drop)

ejgallego / coq-lsp

Visual Studio Code Extension and Language Server Protocol for Coq

GNU Lesser General Public License v2.1

143 stars 31 forks source link

Adapt to coq/coq#18771 (Improve handling of Drop) #677

Closed afdw closed 4 months ago

SkySkimmer commented 4 months ago

Please merge now

ejgallego commented 4 months ago

@SkySkimmer you folks have permission to merge, the process can be streamlined tho, this is what I do:

$ hub checkout https://github.com/ejgallego/coq-lsp/pull/677
$ git rebase main
$ make submodules-update
$ git add vendor/coq vendor/coq-serapi
$ git commit --amend
$ git push --force ....

SkySkimmer commented 4 months ago

Don't you need some signing stuff?

ejgallego commented 4 months ago

Don't you need some signing stuff?

Oh, indeed there is a bug open about that. I'll look into it ASAP.

The thing is that I was advised that some form of commit "signing" is recommended these days, let me see how I can make that not be a problem for overlays.

Alizter commented 4 months ago

Issue is https://github.com/ejgallego/coq-lsp/issues/489. We can probably get rid of commit signing. I don't see why it would be useful for us.