Closed Alizter closed 4 months ago
Getting the data should not be hard, questions:
I think if we want it to be incremental the server should notify the client. Presumably when we do the progress updates.
Right now the data is refreshed everytime you move the cursor or activate the window which obviously doesn't scale too well. I would prefer that this is refreshed when a notification is recieved. The colouring is relative, so if we get a line with a large value relative to the rest, all the lines will need to be recoloured.
Ok, rebased and working now!
IMHO I would cleanup this a bit, add an example, and maybe merge. I guess the heatmap will require some fine tuning with real files, but even in basic form that's a very cool addition.
This appears to be working really well. The configuration options also appear to work, though it is very likely there are some bugs. I set it up so that the options update the heatmap in real time without having the reload the extension which might be useful.
I think I want to add a hover functionality in heatmap mode so that we can actually see the values being highlighted. We obviously have something via the debug stats, but having something more user facing might be useful.
Indeed, once the bugs in the backend were fixed, this seems to be pretty nice and not too complex!
I think I want to add a hover functionality in heatmap mode so that we can actually see the values being highlighted. We obviously have something via the debug stats, but having something more user facing might be useful.
Maybe we could re-use the existing hover for performance data, in order to do this, we'd need:
OK that is a bit more complex than I imagined. I think I will leave that as a feature request for now as to not stall this feature.
@ejgallego I think this is ready.
Maybe also squash if you want.
@ejgallego Changelogs updated and commits squashed.
Here is a proof-of-concept for #681. Currently we generate random data and display that instead. I haven't been able to workout how we can get timing data yet.Here is a PR implementing #681. We add an optional heatmap overlay to a file which visualizes the performance data. The screenshot below shows the timing data in a file being visualized.
TODO