[code] Correctly dispose even if client shutdown fails.

ejgallego / coq-lsp

Visual Studio Code Extension and Language Server Protocol for Coq

GNU Lesser General Public License v2.1

151 stars 31 forks source link

[code] Correctly dispose even if client shutdown fails. #708

Closed ejgallego closed 4 months ago

ejgallego commented 4 months ago

This was likely causing some problems on extension restart.

Still we need to improve how we manage lifetime events.

Alizter commented 4 months ago

I've ran into all sorts of bugs with the extension hanging around, but I typically just reload vscode in those cases which nukes any running instances. Unfortunately, I wasn't able to find anything reproducible to report a bug. Hopefully this improves the situation, but it isn't a critical issue.

ejgallego commented 4 months ago

Yes, there are some lifetime problems. This will help in many cases actually!

Another important bug is on extension deactivation, we are doing context.subscriptions.push of object that actually have server-bound lifetime, not extension bound!