search

ejgallego / coq-lsp

Visual Studio Code Extension and Language Server Protocol for Coq
GNU Lesser General Public License v2.1
137 stars 31 forks source link

[code] Add keybindings for sentenceNext / sentencePrevious #718

Closed ejgallego closed 2 months ago

ejgallego commented 2 months ago

Alt+N / Alt+P

Alizter commented 2 months ago

My only worry is that these default key bindings might not be so obvious for people coming from other platforms.

Also I would suggestAlt+B for Alt + Back rather than P. The same keys are used for selecting search results in vim so maybe I am biased.

Using Ctrl is not an option since it messes with other bindings in vscode.

Alizter commented 2 months ago

Alternatively, we could rename sentenceBack to sentencePrev and keep the key binding. That would actually sound more correct.

ejgallego commented 2 months ago

Yeah, Alt-P (previous) and Alt-N (next) are standard Emacs bindings, so I dunno. For experienced Coq users this make make sense due to ProofGeneral being the most used Coq IDE, but I dunno for others.

I propose we stick to Alt-N/P for now as they have much better hand ergonomy than Alt-B

ejgallego commented 2 months ago

Alternatively, we could rename sentenceBack to sentencePrev and keep the key binding. That would actually sound more correct.

Ok let's do that.