ejholmes / active_admin_editor

Rich text editor for Active Admin using wysihtml5.
MIT License
184 stars 134 forks source link

Undefined mixin 'box-shadow' #63

Open Ruff9 opened 9 years ago

Ruff9 commented 9 years ago

The gem is currently unusable, due to a missing mixin, 'box-shadow'.

There is a pull request waiting, #62, that seems to deal with this problem.

tlindsay commented 9 years ago

I can't find the comment thread now, but I believe the master branch has already fixed this issue. The problem is that the gem at rubygems hasn't been updated to reflect that. Some people have had luck with this (SO answer), however it's not working in my production environment and we're having to hardcode a fix.

ravindra9278 commented 8 years ago

I have the same problem , when I have installed the editor gem after that i got this error .

Sass::SyntaxError in ActiveAdmin::Devise::Sessions#new

Showing /home/daffolap-198/.rvm/gems/ruby-2.2.1@echovalley_mall/bundler/gems/activeadmin-6bce892a2cca/app/views/layouts/active_admin_logged_out.html.erb where line #9 raised:

Undefined mixin 'box-shadow'. (in /home/daffolap-198/.rvm/gems/ruby-2.2.1@echovalley_mall/gems/active_admin_editor-1.1.0/app/assets/stylesheets/active_admin/editor.css.scss:25)

Extracted source (around line #25):

23 24 25 26 27 28 &:focus { @include box-shadow(none); border: 1px solid #C9D0D6; border-top: 1px solid lighten(#C9D0D6, 10%); }

DidiRaggio commented 8 years ago

I was using gem 'active_admin_editor', github: 'ejholmes/active_admin_editor'

but would get a problem when running bundle install

active_admin_editor at c:/RailsInstaller/Ruby2.1.0/lib/ruby/gems/2.1.0/bundler/g ems/active_admin_editor-86f964be3071 did not have a valid gemspec. This prevents bundler from installing bins or native extensions, but that may no t affect its functionality. The validation message from Rubygems was: duplicate dependency on activeadmin (~> 0.4.3, development), (>= 0.4.0) use: add_runtime_dependency 'activeadmin', '~> 0.4.3', '>= 0.4.0' Using active_admin_editor 1.1.0 from git://github.com/ejholmes/active_admin_edit or.git (at master)

The problem seems to be solved with

gem 'active_admin_editor', github: 'boontdustie/active_admin_editor'

So... thanks boontdustie!

Sgemini commented 8 years ago

i have the same question. gem 'active_admin_editor', github: 'ejholmes/active_admin_editor'this is work for me.

lukasz-wojcik commented 7 years ago

When using gem and pointing to github I usually use ref in order to provide the hash of commit that I want to use. This prevents from unexpected updates.

gem 'active_admin_editor', github: "ejholmes/active_admin_editor", ref: "86f964be3071cd938c3cd17ad00df94ece3a50c0"

m5rk commented 7 years ago

@lukasz-wojcik That's what Gemfile.lock is for.

lukasz-wojcik commented 7 years ago

Of course lock stores that but having that ref in Gemfile is also servers an informational purpose for me so that I really want that particular version. So someone else who performs gem updates will stop and think for a while why it is there. Not once Minor version change introduces a breaking change in a gem. But most of the times it is not required to provide ref.

t-deetiw commented 7 years ago

@ejholmes Any plan on fixating this issue on this GitHub repo, since this one is available on Rubygems site.

To fix this we can point to another forked repo which has the fix gem 'active_admin_editor', git: 'https://github.com/boontdustie/active_admin_editor'

But we were expecting that rubygems linked repo would have the fix sooner or later, since any new installation from the site will be broken.

It would be great if you could do this, if there is some constraint then let us know and we will go via previous approach.

Darrenbydesign commented 6 years ago

any updates on this getting officially fixed? I was having the same issue and the only resolution seems to be an insecure one