search

ejmahler / RustFFT

RustFFT is a high-performance FFT library written in pure Rust.
Apache License 2.0
678 stars 47 forks source link

Reduce trait impl duplication and rename DoubleBuff to DoubleBuf #115

Closed groscoe2 closed 1 year ago

groscoe2 commented 1 year ago

Partially addresses trait impl duplication mentioned in comment in #113. The duplicate_item macro from the duplicate crate should be sufficient to address the rest of the duplication. I can add that to this PR if desired!

groscoe2 commented 1 year ago

@ejmahler I believe this is good to go for review. Now that there are only two duplicate impls for each of AvxArray, SseArray, and NeonArray, I think adding duplicate as a dependency is unnecessary. However, it is quite straightforward to eliminate this duplication using that crate if you believe it makes sense to do so.

ejmahler commented 1 year ago

Looking great. I'm curious what happened with the prime butterfly files, it's like rustfmt only now decided to do anything about them.

groscoe2 commented 1 year ago

@ejmahler I've reverted the auto-formatting changes for both prime butterflies files. It turns out that rust nightly is required for the ignore config in rustfmt.toml to work, and I've been using stable for all my development. It would be good to update the contribution section on the readme to reflect this (along with increasing the MSRV)!