Avoid 500 response codes - Githubissues

ejnnr / web-chess

A web implementation of a chess database program like Scid.

MIT License

7 stars 4 forks source link

Avoid 500 response codes #25

Closed ejnnr closed 8 years ago

ejnnr commented 8 years ago

There are currently a lot of cases where 500 is returned when there would be a better alternative:

When an invalid game is shown (should be stopped by returning 422 on creation)
When a non-authenticated user tries to access /api/user (should be 401)
When trying to access a non-existent resource id (should be 404)

Also 403 should be turned to 401 if the client isn't authenticated.