search

ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
796 stars 68 forks source link

Don't include commit-id if not creating stacked commits #267

Closed danielcompton closed 2 years ago

danielcompton commented 2 years ago

Many of my commits are not using spr. However, they still get commit-id appended to the commit message.

Ideally I'd be able to not have any commit-ids in my commit messages until I created a stacked pull request. Then spr would go through the commits about to be converted into PRs and assign a commit-id then.

ejoffe commented 2 years ago

@danielcompton - I really have to thank you! At first I dismissed this idea as not a big deal, but the whole commit-msg hook was always annoying me. The need to install a hook into the .git/hooks dir always left a bad taste for me, but I couldn't think of another way. This issue has caused me to rethink the whole message hook and instead now spr will just use a magical rebase to add the commit-ids while updating the prs. This solves your issue of having commit-ids in commits that aren't using spr, but also removes the whole need for the commit hook. Thank you!