ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
796 stars 68 forks source link

Check goreleaser config in CI github workflow #344

Closed kwk closed 1 year ago

kwk commented 1 year ago

This adds a check to the CI workflow file to check for the sanity of the .goreleaser.yml file by running goreleaser check.

ejoffe commented 1 year ago

@kwk - looks like the latest go releaser updates broke the brew install.

Error: invalid attribute for formula 'ejoffe/tap/spr': url ("https://github.com/ejoffe/spr/releases/download/v0.13.1/spr_darwin_x86_64 .tar.gz")
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/formula.rb:293:in `validate_attributes!'
/usr/local/Homebrew/Library/Homebrew/formula.rb:223:in `initialize'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:483:in `new'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:483:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:643:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:762:in `factory'
/usr/local/Homebrew/Library/Homebrew/cli/parser.rb:647:in `block in formulae'
/usr/local/Homebrew/Library/Homebrew/cli/parser.rb:643:in `map'
/usr/local/Homebrew/Library/Homebrew/cli/parser.rb:643:in `formulae'
/usr/local/Homebrew/Library/Homebrew/cli/parser.rb:316:in `parse'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:127:in `upgrade'
/usr/local/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'
ejoffe commented 1 year ago

Looks like goreleaser is messing up the urls inside the brew tap and adding a space, I'm not sure why... I fixed the space issue in the tap manually, but still need to figure out what is it in the new naming method in go releaser that is adding these spaces.

kwk commented 1 year ago

@ejoffe sorry for not noticing this earlier. I have created a fix here #345.