ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
796 stars 68 forks source link

Add option to show status in font without emojis #357

Closed b-chu closed 11 months ago

b-chu commented 1 year ago

When ssh into a remote instance, system fonts don't properly render the bits for status, update, or merge. It would be great to add a config option to display bits that are supported for all fonts.

Sample output below:

> git spr status
> git rev-parse --show-toplevel
> github fetch pull requests
> git log --format=medium --no-color upstream/dev..HEAD
> git branch --no-color
[____] https://github.com/mosaicml/composer/pull/2593 : Add Rank Planners
[____] https://github.com/mosaicml/composer/pull/2584 : Update types to follow PEP 585
[____] https://github.com/mosaicml/composer/pull/2582 : Add SavePlanner and LoadPlanner support in Trainer
ejoffe commented 1 year ago

Use statusBitsEmojis in the User config.

b-chu commented 1 year ago

No matter if I set it as true or false, it doesn't render properly

ejoffe commented 1 year ago

Gotcha, I'll add a basic status bits, these are the current set:

        asciiCheckmark = "✔"
    asciiCrossmark = "✗"
    asciiPending   = "·"
    asciiQuerymark = "?"
    asciiEmpty     = "-"
    asciiWarning   = "!"

checkmark and crossmark are most likely missing, pending might also be an issue. any suggestion for which chars to use for these? crossmark can be 'X' checkmark can be 'V' ? pending can be '.'

b-chu commented 1 year ago

I think the current set is extended ASCII? I personally prefer lowercase x v, but both are fine. https://theasciicode.com.ar/

ejoffe commented 11 months ago

Your change released in v0.14.4. Thank you for the contribution!