ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
714 stars 65 forks source link

add --no-verify to git amend #366

Open b-chu opened 7 months ago

b-chu commented 7 months ago

There should be a way to skip pre-commit hooks

ejoffe commented 7 months ago

Can you add more details please. In what cases would you want to skip commit hooks?

b-chu commented 7 months ago

When using git amend

ejoffe commented 7 months ago

Are these custom pre-commit hooks that you have? or the commit msg hook that spr runs while updating the stack?

b-chu commented 7 months ago

git commit allows for --no-verify and spr uses git commit but doesn't allow for --no-verify https://git-scm.com/docs/git-commit

ejoffe commented 7 months ago

git amend uses git commit --fixup + git rebase if you want to add --no-verify there it's possible. the code is in:

cmd/amend/main.go
spr/spr.go : AmendCommit function

Pull requests are welcome.

piefel commented 6 months ago

Is this the same as or only quite similar to #293 ?