search

ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
794 stars 68 forks source link

Remove merge queue from query is feature is disabled #370

Closed ejoffe closed 9 months ago

ejoffe commented 10 months ago

fixes #356

commit-id:0219e1da

ejoffe commented 10 months ago

Ah, you are correct. My bad. Will flip it.

pleicht commented 10 months ago

Looks right to me. The condition is to skip this field if use_merge_queue == true.

I tested it locally when building this branch and I get the error for merge queue. I think we only want to generate the MergeQueue section if use_merge_queue is true, if false we exclude

ejoffe commented 10 months ago

Should be correct now. Good catch.

pleicht commented 9 months ago

Not sure if I'm doing something wrong with my local build, but I'm getting: 

panic: query PullRequests.viewer.pullRequests.nodes.mergeQueueEntry: Field 'mergeQueueEntry' doesn't exist on type 'PullRequest'
query PullRequests: Variable $no_merge_queue is declared by PullRequests but not used
ejoffe commented 9 months ago

I guess the skip directive doesn't work in this case, will try another approach.

pleicht commented 9 months ago

I guess the skip directive doesn't work in this case, will try another approach.

👍, thanks for the help and spr in general, I really enjoy using it!

ejoffe commented 9 months ago

Much more involved fix pushed. I think this one should work for you. Let me know.