Support reading github token from system encrypted storage - Githubissues

ejoffe / spr

Stacked Pull Requests on GitHub

MIT License

714 stars 65 forks source link

Support reading github token from system encrypted storage #373

Open phanhuyn opened 6 months ago

phanhuyn commented 6 months ago

Why

Currently, spr retrieves the github token from plaintext config: https://github.com/ejoffe/spr/blob/66dd2f0dab7369ab227b01aa76eed237ab3d3b60/github/githubclient/client.go#L80
Since git cli 2.24.0, gh auth login supports --secure-storage by default, and stores the token in system encrypted storage.
This causes spr to fail with No GitHub OAuth token found!

What

Support retrieving token from system encrypted storage