ejoffe / spr

Stacked Pull Requests on GitHub
MIT License
714 stars 65 forks source link

update gh login instructions after gh CLI storage update #396

Closed levibostian closed 3 months ago

levibostian commented 3 months ago

As shared in this comment, gh cli has changed the default behavior of how github auth tokens are saved. This change makes spr no longer able to read github auth tokens and has caused myself and others confusion when instructions say to run gh auth login but still see spr not be able to find the token.

This change updates the instructions to avoid this confusion. I do understand that suggesting to users to use insecure storage may not be ideal and a different solution may be preferred. Whatever solution it is, I believe it's better then today where users of spr receive these help docs, try them, and do not see success.