search

ejokeeffe / tradedownloader

Download trade data from Comtrade using the exposed Comtrade API
14 stars 5 forks source link

CSV File not available for download #9

Open SteveClement opened 6 years ago

SteveClement commented 6 years ago

Yeah, not sure anyone still uses this actually, but the next roadblock is the "UN Comtrade Country List.csv" file.

Currently only an "xls" exists, and of course JSON. On: http://unstats.un.org/unsd/tradekb/Knowledgebase/Comtrade-Country-Code-and-Name

I will play a little around with exporting the xls, if this repo is dead, please mark it appropriately.

Cheers.

ejokeeffe commented 6 years ago

@SteveClement - not sure how this is a roadblock. It says in the readme that you have to download the file. If it's in json, then you just need to convert it.

But you're right, no amends to this repo in a while. Feel free to PR if there's anything you want to change.

BTW - how do you mark a repo as dead? Didn't think you could or don't know why you would necessarily.

SteveClement commented 6 years ago

I tried the conversion but hit a roadblock. Some things seem to have changed.

If I fix something I will PR the changes.

There is no official way of putting a repo into "dead" mode.

But imagine your code would only be 2.7 compatible and after x years, stuff becomes obsolete anyway etc. It is up for debate I suppose ;)

Thanks for the reply.

ejokeeffe commented 6 years ago

Thanks @SteveClement. Please do PR any bug fixes or enhancements. Might be just easier to change the code so it reads the json - rather than doing a json to csv conversion before running it.

The code still works for me - last time i tried it was a couple of months ago (on 3.4 if i remember rightly), so it should be ok. But let me know if you hit problems.