search

ejona86 / taus

Tetris - Actually Useful Statistics and other mods
MIT License
91 stars 3 forks source link

[2-Player] B-Type Issues #18

Closed SapphireBulletBill closed 3 years ago

SapphireBulletBill commented 4 years ago

This is already an awesome modification. However, B-Type has a couple problems. (This was encountered on the "Next-on-top" version, though I'd expect it to be the same on the other version)

ejona86 commented 4 years ago

@DanKruse731, what version of the hack are you using? Where did you get it? I tested v1.1.1, v1.2.0, and master with next-on-top and don't see any problem. I tried both p1 and p2 dying first. Super-early versions of the hack did crash when one player died, but those aren't widely distributed.

SapphireBulletBill commented 4 years ago

@DanKruse731, what version of the hack are you using? Where did you get it? I tested v1.1.1, v1.2.0, and master with next-on-top and don't see any problem. I tried both p1 and p2 dying first. Super-early versions of the hack did crash when one player died, but those aren't widely distributed.

I'm using release 1.2.0

ejona86 commented 4 years ago

Oh, I found it. It's when you complete B type normally, without dying. Yeah, I totally missed that code path and didn't consider testing it.

This is probably pretty easy to fix, but I'll also need to look back at how I fixed Type A, and I remember that had some ugly code to avoid messing up some common GameGenie codes.

ejona86 commented 3 years ago

Thanks for filing the issue! It turned out to be easy to fix it in a basic way, but quite a bit more involved to have the music play as I wanted. I ended up getting it though. v1.3.0 includes the fix.