Wip/rib/build fixes - Githubissues

ejona86 / taus

Tetris - Actually Useful Statistics and other mods

MIT License

89 stars 3 forks source link

Wip/rib/build fixes #8

Closed rib closed 4 years ago

rib commented 4 years ago

Hi, I found I needed to make a few small tweaks to Makefile and nes.mk to get make to build under Ubuntu 18.04

ejona86 commented 4 years ago

Looking at https://github.com/TGGC/taus/commit/f93bde51464c8ea22531a96c5f05e5156c425705 it appears split may also cause some trouble. It'll be a few days before I can spin up an Ubuntu VM again to test and compare.

ejona86 commented 4 years ago

This is partially supplanted by #9. Using xxd instead of basez seems a clear win. The first commit of this PR to specify SHELL is still fair game, since it is fairly common practice, but it is no longer as important as it was.

rib commented 4 years ago

all good comments, thanks - I'm happy with the alt fixes you merged so also happy to close this PR, the only reason I had for specifying the SHELL was for the bashisms which have been removed so will leave it up to you if you also want to specify the SHELL explicitly.

ejona86 commented 4 years ago

Closing. Travis is now set up and runs Ubuntu, so any new bash-isms should be noticed.

Thank you! It is much easier to use on Ubuntu now!