search

ejp-rd-vp / CDE-semantic-model

Semantic data model of the set of common data elements for rare disease registration
Creative Commons Zero v1.0 Universal
12 stars 9 forks source link

Which personShape is correct? #100

Closed henrietteharmse closed 3 years ago

henrietteharmse commented 3 years ago

In personShape.shex it is defined as follows: 

:personShape IRI { 
  a [sio:SIO_000498] ;
  sio:SIO_000228 @:roleShape ;
  obo:RO_0002162 @:taxonShape 
}

In patientStatusShape.shex it is defined as:

:personShape IRI {
  a [sio:SIO_000498];
  sio:SIO_000228 @:personRoleShape;
  sio:SIO_000217 @:statusQualityShape
}

As far as I can see both use the same IRI, however the shape definitions are different. If we do need 2 different shapes for person I think we need 2 different IRIs.

henrietteharmse commented 3 years ago

@rajaram5 Do you have any thoughts on this?

rajaram5 commented 3 years ago

Hi @henrietteharmse . The second shape is the correct one. One of the very first model is based on the first shape but later we decide to use sio as much as possible which resulted in the second shape. Thanks for reporting it. I will delete the first shape which is not valid anymore.

henrietteharmse commented 3 years ago

@rajaram5 Thanks for clarifying.