search

ejp-rd-vp / CDE-semantic-model

Semantic data model of the set of common data elements for rare disease registration
Creative Commons Zero v1.0 Universal
12 stars 9 forks source link

Develop #102

Closed pabloalarconm closed 2 years ago

pabloalarconm commented 2 years ago

Hi @pabloalarconm, I added some corrects. A general comment can you use non cap char for the rdf:label values? For example you can replace labels like information content entity Process Input by Information content entity process input

Yes, cap letters are added by default due to Mark's yarrrml builder, but we will edit the code in order to generate better labels for this cases.

markwilkinson commented 2 years ago

This would no longer use the height yarrrml. It would use the generic body_measurement_template... so the example data should probably reflect that.

markwilkinson commented 2 years ago

@pabloalarconm this is some sample data for weight that follows the generic body measurement template

abc123,16346450306990402,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,75.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2019-05-17,"" abc456,16346450313055491,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,45.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2020-02-28,"" abc678,16346450313056872,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,45.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2020-02-28,""

pabloalarconm commented 2 years ago

This would no longer use the height yarrrml. It would use the generic body_measurement_template... so the example data should probably reflect that.

There's no height-based exemplar data for a long time, we are using your body_measurement_template to generate the exemplar data :)

pabloalarconm commented 2 years ago

@pabloalarconm this is some sample data for weight that follows the generic body measurement template

abc123,16346450306990402,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,75.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2019-05-17,"" abc456,16346450313055491,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,45.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2020-02-28,"" abc678,16346450313056872,http://purl.obolibrary.org/obo/VT_0001259,body mass,http://purl.obolibrary.org/obo/NCIT_C112025,Mass measurement,45.0,xsd:float,http://purl.obolibrary.org/obo/UO_0000009,kilogram,2020-02-28,""

Could you send me the new column names too?

markwilkinson commented 2 years ago

they're the same as in the sample csv for the body measurement yarrrml