ejp-rd-vp / CDE-semantic-model

Semantic data model of the set of common data elements for rare disease registration
Creative Commons Zero v1.0 Universal
12 stars 9 forks source link

ShEx for Module "Care Pathway" and "Disease History and Diagnosis" #48

Closed sxzhang1201 closed 3 years ago

sxzhang1201 commented 3 years ago

Dear all,

I create ShEx for the modules "care pathway" and "disease history and diagnosis", which comply with the diagrams (https://github.com/ejp-rd-vp/CDE-semantic-model/wiki/Care-pathway-SIO and https://github.com/ejp-rd-vp/CDE-semantic-model/blob/develop/images/5_Disease_history_and_diagnosis_SIO.png).

Thank @markwilkinson for your "example turtle". I validate it against the ShEx, which turns out some conflicts:

What ShEx (Diagram) Turtle How is it in Core Model
Type of Person Node sio:person sio:patient sio:person is used
Type of Patient Role Node sio:patient-role sio:patient-role, sio:role only sio:patient-role is used
Relationship between bithDateQualityShape and its output sio:has-measurement-value sio:has-measurement-value In diagrams of other modules, sio:is-base-for is used
Type of birthDateOutputShape sio:realizable-entity sio:measurement_value In diagrams of other modules, sio:realizable-entity is used
Medical Diagnosis as a mandatory node connecting to role and its output Missing Such inconsistency leads to "missing-property rrrors" from Role instances

Look forward to suggestions and reviews.

sxzhang1201 commented 3 years ago

@sxzhang1201 I have updated both care pathway and disease modules. My PR is still under review. If my changes are accepted then you have to change ur shex too. I will give you heads up when my PR is merged. Can you update this PR after that please?

Sure, I will review yours first 👍