ejplatform / ej-server

EJ uses gamification and machine learning to promote discussions and participation in a virtual democracy
https://ejplatform.github.io/ej-server/
Other
38 stars 17 forks source link

[REVIEW] Fix profile image input #498

Closed MatheusRich closed 6 years ago

MatheusRich commented 6 years ago

Descrição

Removi o código comentado do input e usei uma label para abrir o input de imagem que está hidden.

Aproveitei pra melhorar um pouco o layout da página. Segue o antes e o depois.

Antes: image

Depois: image

Issues Relacionadas

resolves #425

Checklist

codecov[bot] commented 6 years ago

Codecov Report

Merging #498 into develop will decrease coverage by 1.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #498      +/-   ##
==========================================
- Coverage    73.14%   72.1%   -1.05%     
==========================================
  Files          122     120       -2     
  Lines         3121    3087      -34     
  Branches       339     338       -1     
==========================================
- Hits          2283    2226      -57     
- Misses         733     760      +27     
+ Partials       105     101       -4
Impacted Files Coverage Δ
src/ej_boards/rules.py 54.54% <0%> (-9.1%) :arrow_down:
src/ej_boards/middleware.py 72.72% <0%> (-4.55%) :arrow_down:
src/ej_profiles/routes.py 62.26% <0%> (-2.03%) :arrow_down:
src/ej_conversations/routes/admin.py 45.83% <0%> (-1.11%) :arrow_down:
src/ej_clusters/routes.py 60.86% <0%> (-0.75%) :arrow_down:
src/ej_conversations/models/conversation.py 90.59% <0%> (-0.24%) :arrow_down:
src/ej_profiles/forms.py 100% <0%> (ø) :arrow_up:
src/ej_boards/routes/boards.py
src/ej_boards/routes/__init__.py
src/ej_boards/routes/conversations.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5d9bc8...e2c3384. Read the comment docs.