ejplatform / ej-server

EJ uses gamification and machine learning to promote discussions and participation in a virtual democracy
https://ejplatform.github.io/ej-server/
Other
38 stars 17 forks source link

[REVIEW] Refactor javascript for create dynamic stereotype forms #499

Closed rodrigocam closed 5 years ago

rodrigocam commented 5 years ago

Descrição

Alguns bugs foram encontrados ao criar e editar stereotypes pois os formulários são dinâmicos.

Issues Relacionadas

resolves: #473

Checklist

Imagens/Comentários

codecov[bot] commented 5 years ago

Codecov Report

Merging #499 into develop will decrease coverage by 1.03%. The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #499      +/-   ##
===========================================
- Coverage    73.08%   72.04%   -1.04%     
===========================================
  Files          122      120       -2     
  Lines         3113     3091      -22     
  Branches       339      339              
===========================================
- Hits          2275     2227      -48     
- Misses         733      763      +30     
+ Partials       105      101       -4
Impacted Files Coverage Δ
src/ej_clusters/routes.py 59.37% <25%> (-2.25%) :arrow_down:
src/ej_boards/rules.py 54.54% <0%> (-9.1%) :arrow_down:
src/ej_boards/middleware.py 72.72% <0%> (-4.55%) :arrow_down:
src/ej_conversations/routes/admin.py 45.83% <0%> (-1.11%) :arrow_down:
src/ej_conversations/models/conversation.py 90.59% <0%> (-0.24%) :arrow_down:
src/ej_boards/routes/boards.py
src/ej_boards/routes/__init__.py
src/ej_boards/routes/conversations.py
src/ej_boards/routes.py 40.78% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 055a1e2...ef15dd2. Read the comment docs.

fabiolamfleury commented 5 years ago

Outro detalhe, faltou excluir o arquivo js que gerava os formulários dinamicamente

rodrigocam commented 5 years ago

@fabiolamfleury acredito ter corrigido tudo que foi dito, se puder dar uma olhada o/