search

ejplatform / ej-server

EJ uses gamification and machine learning to promote discussions and participation in a virtual democracy
https://ejplatform.github.io/ej-server/
Other
38 stars 17 forks source link

[REVIEW] Testes e pequenas correções de bugs #575

Closed fabiolamfleury closed 5 years ago

fabiolamfleury commented 5 years ago

Descrição

Criação de testes em apps do ej que possuem menor cobertura. Durante a criação de testes foi encontrado um bug no arquivo math.py do ej_clusters, que ainda usava um filtro do atributo username de user (que existe agora como propriedade) esse bug foi corrigido nessa branch!

Issues Relacionadas

resolves: #250 resolves: #603

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #575 into develop will increase coverage by 8.33%. The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #575      +/-   ##
===========================================
+ Coverage    73.47%   81.81%   +8.33%     
===========================================
  Files          121      121              
  Lines         3220     3201      -19     
  Branches       347      343       -4     
===========================================
+ Hits          2366     2619     +253     
+ Misses         752      482     -270     
+ Partials       102      100       -2
Impacted Files Coverage Δ
src/ej_conversations/validators.py 60% <ø> (-6.67%) :arrow_down:
src/ej_conversations/roles.py 66.66% <ø> (-0.73%) :arrow_down:
src/ej_clusters/math.py 55.88% <0%> (+22.05%) :arrow_up:
src/ej_profiles/routes.py 98.03% <100%> (+34.4%) :arrow_up:
src/ej_clusters/routes.py 96.11% <100%> (+35.92%) :arrow_up:
src/ej_configurations/models.py 86.66% <100%> (-0.18%) :arrow_down:
src/ej_conversations/forms.py 100% <100%> (+40%) :arrow_up:
src/ej_configurations/validators.py 87.5% <90%> (+4.16%) :arrow_up:
src/ej/jinja2.py 76.92% <0%> (+1.92%) :arrow_up:
src/ej/roles/tags.py 73.91% <0%> (+2.17%) :arrow_up:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7e12f3...e966344. Read the comment docs.