ejplatform / ej-server

EJ uses gamification and machine learning to promote discussions and participation in a virtual democracy
https://ejplatform.github.io/ej-server/
Other
38 stars 17 forks source link

[REVIEW] Bug modais #686

Closed LeoSilvaGomes-zz closed 5 years ago

LeoSilvaGomes-zz commented 5 years ago

Descrição

Issues Relacionadas

678

Checklist

Imagens/Comentários

Antes 49460167-da761080-f7d7-11e8-852a-2e2c43b8774d

Depois screenshot from 2018-12-05 15-10-43

LeoSilvaGomes-zz commented 5 years ago

"Modais só devem aparecer no primeiro acesso do usuário"

@ricardopoppi Gostaria de saber se podemos fazer as modais aparecerem no momento em que a pessoa fizer o login ao invés de ser quando a pessoa entra na conversa

ricardopoppi commented 5 years ago

@LeoSilvaGomes acho que essa abordagem dos modais aparecerem para o usuário logo após o login, e uma única vez é ótima. Pode seguir em frente assim.

codecov[bot] commented 5 years ago

Codecov Report

Merging #686 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #686   +/-   ##
========================================
  Coverage    78.52%   78.52%           
========================================
  Files          141      141           
  Lines         3996     3996           
  Branches       448      448           
========================================
  Hits          3138     3138           
  Misses         724      724           
  Partials       134      134

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16176bc...3303e6b. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #686 into develop will increase coverage by 0.24%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
+ Coverage    78.32%   78.57%   +0.24%     
===========================================
  Files          142      141       -1     
  Lines         4051     4004      -47     
  Branches       455      449       -6     
===========================================
- Hits          3173     3146      -27     
+ Misses         744      724      -20     
  Partials       134      134
Impacted Files Coverage Δ
src/ej_profiles/routes.py 98.03% <ø> (ø) :arrow_up:
src/ej_boards/routes.py 89.28% <ø> (ø) :arrow_up:
src/ej_conversations/routes/conversations.py 96.49% <100%> (+0.41%) :arrow_up:
src/ej_users/routes.py 70% <100%> (+0.5%) :arrow_up:
src/ej_conversations/roles.py 80% <0%> (-1.67%) :arrow_down:
src/ej_conversations/models/conversation.py 87.14% <0%> (-1.38%) :arrow_down:
src/ej_users/models.py 97.67% <0%> (-0.16%) :arrow_down:
src/ej_conversations/routes/admin.py 100% <0%> (ø) :arrow_up:
src/ej/settings/apps.py 65.21% <0%> (ø) :arrow_up:
src/ej_notifications/forms.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e01738...254361b. Read the comment docs.