Stats shows incorrect environment

[srijak]

Hello,

Thanks for creating this project: it's been easy to setup and use.

I came across the following issue and would love some clarification.

In the Stats page, the environment label is sourced from Sinatra::Application.environment[0], which depends on a APP_ENV enviroment variable[1].

It looks like setting this up doesn't affect anything other than that specific label because the DB connection used to get DelayedJob(s) is whatever rails is setup to use.

Is that correct? If so, would it make more sense to use the rails env value?

[0]https://github.com/ejschmitt/delayed_job_web/blob/master/lib/delayed_job_web/application/views/stats.erb#L8 [1]http://sinatrarb.com/configuration.html

[andyatkinson]

Hi @srijak - I don't have a test instance of this running, would you mind including a screenshot?

If you think this column is confusing or not very useful, we could simply remove it too. Or if you think a different label makes more sense, that works. What do you think would be best?

[coffeejunk]

I think I'm seeing the same issue:

$ bin/www
=> Booting Puma
=> Rails 5.2.3 application starting in production
=> Run `rails server -h` for more startup options
Puma starting in single mode...
* Version 3.12.0 (ruby 2.5.1-p57), codename: Llamas in Pajamas
* Min threads: 5, max threads: 5
* Environment: production
* Listening on tcp://0.0.0.0:8082
Use Ctrl-C to stop

[andyatkinson]

@coffeejunk Would you like to submit a PR based on what @srijak said earlier, using the Rails env instead? Or not displaying anything if the ENV is not set, that might be another solution.

[coffeejunk]

@andyatkinson sure thing