search

ejschmitt / delayed_job_web

Resque like web interface for delayed job
MIT License
478 stars 188 forks source link

Best option to remove sensitive arguments from the UI? #114

Open dedman opened 5 years ago

dedman commented 5 years ago

Hey there, I was just trying to stop the UI from showing potentially sensitive arguments unnecessarily. I looked through the code and there doesn't seem to be an easy way to do this even with monkey patching so I forked and modified the job.erb like this https://github.com/shifthealthparadigms/delayed_job_web/commit/8615c0d3ec029b0980e5ad9b1b5a45c04e5311d6

Is that the only option or is there something I missed?

Thanks, we really appreciate the project.

andyatkinson commented 5 years ago

@dedman That seems like a nice feature to add! If you wanted to take inspiration from Rails, perhaps you could add a configuration option like:

Rails.application.config.filter_parameters += [:password]

And introduce a filter_parameters sort of array of symbols to look for, your value could be could be [:arguments], to generalize/externalize what you've done on your fork a bit.

Thoughts?

dedman commented 5 years ago

Hey @andyatkinson thanks for your response, I just submitted a PR with the basics of a config for this. https://github.com/ejschmitt/delayed_job_web/pull/115

Sorry I couldn't get the tests running locally. Let me know what you think.