search

ejschmitt / delayed_job_web

Resque like web interface for delayed job
MIT License
479 stars 188 forks source link

update requeue and reload to use update instead of update_attributes #119

Closed atstockland closed 3 years ago

atstockland commented 3 years ago

update_attributes is deprecated in Rails 6 and is causing error when attempting to retry or reload a job. Simply changing update_attributes to update fixes these issues. This fork is being used in my production app and working like the old days.

andyatkinson commented 3 years ago

@atstockland This makes sense. Would you also be willing to bump the gem version and add a CHANGELOG entry per these instructions: https://github.com/ejschmitt/delayed_job_web#releasing-a-new-version

I believe I may need to perform the actual new gem version release based on permissions on rubygems, but if you can take on this first part that would help. Thanks.

atstockland commented 3 years ago

Hi @andyatkinson. I bumped the version (kinda botched the commit message...not following the example). I also added the version details to the CHANGELOG.

johnmaxwell commented 3 years ago

Is there anything I can do to help release this? The requeue function results in a 500 under Rails 6.1.

andyatkinson commented 3 years ago

I was just thinking about backwards compatibility but it seems fine. I am assuming I still have credentials to create a new rubygems release so I'll merge this and attempt that.

andyatkinson commented 3 years ago

@atstockland @johnmaxwell Thanks for the nudge. I reset my Rubygems account and have release 1.4.4. Thanks for your contributions! https://rubygems.org/gems/delayed_job_web/versions/1.4.4

johnmaxwell commented 3 years ago

Thank you, @andyatkinson and @atstockland !