search

ejschmitt / delayed_job_web

Resque like web interface for delayed job
MIT License
479 stars 188 forks source link

Add Non-Standard delayed_job Columns to the Display #131

Open markbeme opened 1 year ago

markbeme commented 1 year ago

Adding non-standard column names to the display is important for any gems or site-specific modifications that add columns to delayed_jobs like https://github.com/codez/delayed_cron_job (which adds the cron column).

Interestingly, this also adds created_at and updated_at to the Display, something I personally find valuable.

Ideas for improvement on this contribution:

  1. Add a section header at the top, "Standard Attributes".
  2. Add "Created At" and "Updated At" to the bottom of the Standard Attributes.
  3. Add created_at and updated_at to the excluding call in line 63 of the contributed job.erb.
  4. If there are any non-standard columns to process, add some whitespace and a section header, "Non-Standard Attributes", "Additional Attributes", etc.
  5. Output all of the non-standard dt and dd values.
markbeme commented 1 year ago

Tagging @codez for their excellent DelayedCronJob.

markbeme commented 1 year ago

@andyatkinson @ejschmitt @nashby Should I tag someone else who is currently maintaining delayed_job_web to get this PR merged? Would love to eliminate my fork and give this unto the world. Thanks!

markbeme commented 1 year ago

@thegeorgeous are you able to merge this PR? Thanks!

AmritD commented 11 months ago

Would love to see this merged.

andyatkinson commented 11 months ago

@markbeme @AmritD I don't use this anymore. I intended to merge it, but I raised a security concern here that gave me pause. Can you take a look? https://github.com/ejschmitt/delayed_job_web/pull/131/files#r1389677619