search

ejschmitt / delayed_job_web

Resque like web interface for delayed job
MIT License
479 stars 187 forks source link

Enable filtering on handler, last_error and queue #72

Closed DanielZwijnenburg closed 5 years ago

DanielZwijnenburg commented 9 years ago

This PR enables users to search jobs based on handler, last_error and queue. I also renamed @queues to @filters for the sake of clarity.

andyatkinson commented 9 years ago

@DanielZwijnenburg Sorry about the delay. Are you still interested in getting this merged in? If so could you rebase and make any updates that are necessary? Are there any tests to add to help support the change? Thanks.

DanielZwijnenburg commented 9 years ago

I am, will write some specs later this week!

andyatkinson commented 7 years ago

@DanielZwijnenburg Bump

DanielZwijnenburg commented 7 years ago

@andyatkinson it has been a long time, just synced and rebased the latest changes. What is the best way to run this locally en test things?

andyatkinson commented 7 years ago

@DanielZwijnenburg Hello. Well, I'm not sure. Maybe in lieu of some automated integration testing, if you could just exercise your changes, do some filtering, searching or whatever, and add a couple of sentences describing what you did to test, that would be adequate. That way we could put that description into the release notes, in case it introduces a break. We could also create a new file to capture the manual testing steps. Thanks.

DanielZwijnenburg commented 7 years ago

@andyatkinson let me rephrase my question, how can I run this without mounting it in a rails app. I want to see my work in the browser and maybe add some more features.

andyatkinson commented 6 years ago

@DanielZwijnenburg I'm not sure. Although you could generate a Rails 5 app for testing purposes fairly easily. Is this still something you'd like to pursue?

andyatkinson commented 5 years ago

@DanielZwijnenburg Closing this due to inactivity. If this is something you're still interested in, please re-open this PR.