Closed yarikoptic closed 8 years ago
more info -- what is happening is that my terminal size is 111x53 and progressbar indicator from gitinspector starts to climb up ruining previous lines in various spots and even climbs higher than original point where gitinspector was executed
What terminal and shell is this under? I recently changed the behavior of how the progress bar is outputted (using \r). Could you try the master branch version and see if there is a difference?
Was a released version as shipped in debian proper (the latest release). I will check later today the master
On January 19, 2016 3:38:50 AM EST, Adam Waldenberg notifications@github.com wrote:
What system is this under? Are you running the master branch or one of the releases? I recently changed the behavior of how the progress bar is outputted (using \r).
Reply to this email directly or view it on GitHub: https://github.com/ejwa/gitinspector/issues/101#issuecomment-172776087
with master 6.20160114-57-gdaf852e the issue is better but not fixed fully:
(venv) Statistical information for the repository 'git-annex' was gathered on 2016/01/19.
The following historical commit information, by author, was found:
Author Commits Insertions Deletions % of changes
Joey Hess 83 130395 4338 77.36
Sören Brunk Below are the number of rows from each author that have survived and are still intact in the current revision:
Author Rows Stability Age % in comments
Joey Hess 5140 3.9 34.6 7.53
Sören Brunk 8883 43.7 18.4 18.09
As you can see that "Below" injection I have reported in #102 and then "Statistical information ..." one sitting 1 line above where original shell prompt was
Ok. I'm guessing this is a terminal and/or shell issue. I run Debian myself and have no issue. What terminal and shell are you using? With that, I may be able to reproduce it and create a workaround.
Zsh under urxvt. I will check home in different shell/terminal
On January 20, 2016 1:54:27 PM EST, Adam Waldenberg notifications@github.com wrote:
Ok. I'm guessing this is a terminal and/or shell issue. I run Debian myself and have no issue. What terminal and shell are you using? I may then be able to reproduce it and create a workaround.
Reply to this email directly or view it on GitHub: https://github.com/ejwa/gitinspector/issues/101#issuecomment-173323560
I just tried rxvt with bash; same problem. It breaks in this terminal. At least the progress bar updates correctly.
The culprit is the terminal.clear_row() function which seems to break in this terminal. It looks like this terminal parses the \b (backspace) code beyond column zero on the current line and jumps up to the previous line.
I'll see if I can solve this differently in order not to break things in this terminal.
Done. The fix above should resolve it.
E.g. looking at fail2ban repository (gitinspector 0.4.3 from debian) result of running these commands:
looks like