Add new "-M" option, so that -wM would produce both weekly and monthly

ejwa / gitinspector

:bar_chart: The statistical analysis tool for git repositories

GNU General Public License v3.0

2.38k stars 328 forks source link

Add new "-M" option, so that -wM would produce both weekly and monthly #104

Open sobomax opened 8 years ago

sobomax commented 8 years ago

Add new "-M" option, which when used in conjunction with "-w" will cause gitinspector output both monthly and weekly stats for the period in question. It is useful in some cases to have both.

adam-waldenberg commented 8 years ago

Hi @sobomax.

Yes, there might be some credence to adding this. I'm not completely convinced, but it is definitely worth considering.

Some problems with the pull request, before this can even be considered for merging;

Needs "git config" support (see config.py), which also means we need a long option for this.
How do we handle the Age column of the blame output ? As it is now, it shows time in either weeks or months.

sobomax commented 8 years ago

Hi @adam-waldenberg, both suggestions have been implemented. Please check and let me know if anything else needs to be done. Thanks!

adam-waldenberg commented 8 years ago

Thank you. I will play with this. I'm wondering if a -M flag is the best option for this... Maybe removing -w and introducing a "--period" flag that takes a string such as "m" (for months) or "wm" (for weeks and months) would be an idea... It would also make it more flexible. I'm torn, though. I need to think about it :).